From a8cc94c188c085e8788e072017ef21d7b7812a55 Mon Sep 17 00:00:00 2001 From: fiaxh Date: Thu, 4 Jan 2018 21:13:44 +0100 Subject: Show error on invalid TLS certificate --- libdino/src/service/connection_manager.vala | 36 ++++++++++++++++-------- main/data/contact_details_dialog.ui | 1 + main/data/manage_accounts/dialog.ui | 3 ++ main/src/ui/manage_accounts/dialog.vala | 13 ++++++--- xmpp-vala/src/core/stanza_reader.vala | 8 ++++-- xmpp-vala/src/core/stanza_writer.vala | 2 +- xmpp-vala/src/core/xmpp_stream.vala | 43 +++++++++++++++-------------- xmpp-vala/src/module/tls.vala | 4 --- 8 files changed, 66 insertions(+), 44 deletions(-) diff --git a/libdino/src/service/connection_manager.vala b/libdino/src/service/connection_manager.vala index 5fcd66a2..bd22191f 100644 --- a/libdino/src/service/connection_manager.vala +++ b/libdino/src/service/connection_manager.vala @@ -32,12 +32,20 @@ public class ConnectionManager { public enum Source { CONNECTION, SASL, + TLS, STREAM_ERROR } + public enum Reconnect { + NOW, + LATER, + NEVER + } + public Source source; public string? identifier; - public StreamError.Flag? flag; + public Reconnect reconnect_recomendation { get; set; default=Reconnect.NOW; } + public bool resource_rejected = false; public ConnectionError(Source source, string? identifier) { this.source = source; @@ -79,7 +87,8 @@ public class ConnectionManager { } Timeout.add_seconds(60, () => { foreach (Account account in connection_todo) { - if (connections[account].last_activity.compare(new DateTime.now_utc().add_minutes(-1)) < 0) { + if (connections[account].last_activity != null && + connections[account].last_activity.compare(new DateTime.now_utc().add_minutes(-1)) < 0) { check_reconnect(account); } } @@ -164,7 +173,7 @@ public class ConnectionManager { change_connection_state(account, ConnectionState.CONNECTED); }); stream.get_module(PlainSasl.Module.IDENTITY).received_auth_failure.connect((stream, node) => { - set_connection_error(account, ConnectionError.Source.SASL, null); + set_connection_error(account, new ConnectionError(ConnectionError.Source.SASL, null)); change_connection_state(account, ConnectionState.DISCONNECTED); }); stream.received_node.connect(() => { @@ -186,9 +195,13 @@ public class ConnectionManager { connections.unset(account); return; } + if (e is Core.IOStreamError.TLS) { + set_connection_error(account, new ConnectionError(ConnectionError.Source.TLS, e.message) { reconnect_recomendation=ConnectionError.Reconnect.NEVER}); + return; + } StreamError.Flag? flag = stream.get_flag(StreamError.Flag.IDENTITY); if (flag != null) { - set_connection_error(account, ConnectionError.Source.STREAM_ERROR, flag.error_type); + set_connection_error(account, new ConnectionError(ConnectionError.Source.STREAM_ERROR, flag.error_type) { resource_rejected=flag.resource_rejected }); } interpret_connection_error(account); } @@ -199,17 +212,17 @@ public class ConnectionManager { int wait_sec = 5; if (error == null) { wait_sec = 3; - } else if (error.source == ConnectionError.Source.STREAM_ERROR && error.flag != null) { - if (error.flag.resource_rejected) { + } else if (error.source == ConnectionError.Source.STREAM_ERROR) { + if (error.resource_rejected) { connect_(account, account.resourcepart + "-" + random_uuid()); return; } - switch (error.flag.reconnection_recomendation) { - case StreamError.Flag.Reconnect.NOW: + switch (error.reconnect_recomendation) { + case ConnectionError.Reconnect.NOW: wait_sec = 5; break; - case StreamError.Flag.Reconnect.LATER: + case ConnectionError.Reconnect.LATER: wait_sec = 60; break; - case StreamError.Flag.Reconnect.NEVER: + case ConnectionError.Reconnect.NEVER: return; } } else if (error.source == ConnectionError.Source.SASL) { @@ -291,8 +304,7 @@ public class ConnectionManager { } } - private void set_connection_error(Account account, ConnectionError.Source source, string? id) { - ConnectionError error = new ConnectionError(source, id); + private void set_connection_error(Account account, ConnectionError error) { connection_errors[account] = error; connection_error(account, error); } diff --git a/main/data/contact_details_dialog.ui b/main/data/contact_details_dialog.ui index 8fa62398..8ce7306d 100644 --- a/main/data/contact_details_dialog.ui +++ b/main/data/contact_details_dialog.ui @@ -77,6 +77,7 @@ 0 + 0 True True True diff --git a/main/data/manage_accounts/dialog.ui b/main/data/manage_accounts/dialog.ui index 9235f613..2dc2762b 100644 --- a/main/data/manage_accounts/dialog.ui +++ b/main/data/manage_accounts/dialog.ui @@ -88,6 +88,7 @@ True + end True @@ -121,6 +122,7 @@ 0 + 1 True @@ -136,6 +138,7 @@ 0 + 0 True