From 64774241e587eab64b10a0c35dd455f6a2288a55 Mon Sep 17 00:00:00 2001 From: fiaxh Date: Wed, 22 Nov 2017 21:09:39 +0100 Subject: Fix memory leak --- main/src/ui/conversation_titlebar/occupants_entry.vala | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'main/src/ui/conversation_titlebar/occupants_entry.vala') diff --git a/main/src/ui/conversation_titlebar/occupants_entry.vala b/main/src/ui/conversation_titlebar/occupants_entry.vala index d6ce7f68..0646eee7 100644 --- a/main/src/ui/conversation_titlebar/occupants_entry.vala +++ b/main/src/ui/conversation_titlebar/occupants_entry.vala @@ -29,9 +29,9 @@ class OccupantsWidget : MenuButton, Plugins.ConversationTitlebarWidget { private Conversation? conversation; private StreamInteractor stream_interactor; private Window window; + private OccupantMenu.View menu = null; public OccupantsWidget(StreamInteractor stream_interactor, Window window) { - image = new Image.from_icon_name("system-users-symbolic", IconSize.MENU); this.stream_interactor = stream_interactor; @@ -44,8 +44,10 @@ class OccupantsWidget : MenuButton, Plugins.ConversationTitlebarWidget { visible = conversation.type_ == Conversation.Type.GROUPCHAT; if (conversation.type_ == Conversation.Type.GROUPCHAT) { - OccupantMenu.View menu = new OccupantMenu.View(stream_interactor, window, conversation); - set_popover(menu); + OccupantMenu.View new_menu = new OccupantMenu.View(stream_interactor, window, conversation); + set_popover(new_menu); + if (menu != null) menu.destroy(); + menu = new_menu; } } } -- cgit v1.2.3-54-g00ecf