From 5425243203cbf5f86b33c4014c5aa787c6aae856 Mon Sep 17 00:00:00 2001 From: fiaxh Date: Wed, 9 May 2018 23:19:22 +0200 Subject: Fix empty display names, fix update contact roster name --- main/src/ui/add_conversation/conference_list.vala | 2 +- main/src/ui/util/helper.vala | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) (limited to 'main/src') diff --git a/main/src/ui/add_conversation/conference_list.vala b/main/src/ui/add_conversation/conference_list.vala index b9f13432..69e8c952 100644 --- a/main/src/ui/add_conversation/conference_list.vala +++ b/main/src/ui/add_conversation/conference_list.vala @@ -85,7 +85,7 @@ internal class ConferenceListRow : ListRow { this.account = account; this.bookmark = bookmark; - name_label.label = bookmark.name ?? bookmark.jid.to_string(); + name_label.label = bookmark.name != null && bookmark.name != "" ? bookmark.name : bookmark.jid.to_string(); if (stream_interactor.get_accounts().size > 1) { via_label.label = "via " + account.bare_jid.to_string(); } else if (bookmark.name != null && bookmark.name != bookmark.jid.to_string()) { diff --git a/main/src/ui/util/helper.vala b/main/src/ui/util/helper.vala index 6d9218e4..3cadfffb 100644 --- a/main/src/ui/util/helper.vala +++ b/main/src/ui/util/helper.vala @@ -60,9 +60,6 @@ public static string get_conversation_display_name(StreamInteractor stream_inter public static string get_display_name(StreamInteractor stream_interactor, Jid jid, Account account) { if (stream_interactor.get_module(MucManager.IDENTITY).is_groupchat_occupant(jid, account)) { - if (jid.resourcepart == account.resourcepart) { - return account.alias; // FIXME temporary. remove again. - } return jid.resourcepart; } else { if (jid.equals_bare(account.bare_jid)) { @@ -73,7 +70,7 @@ public static string get_display_name(StreamInteractor stream_interactor, Jid ji } } Roster.Item roster_item = stream_interactor.get_module(RosterManager.IDENTITY).get_roster_item(account, jid); - if (roster_item != null && roster_item.name != null) { + if (roster_item != null && roster_item.name != null && roster_item.name != "") { return roster_item.name; } return jid.bare_jid.to_string(); -- cgit v1.2.3-70-g09d2