From 64774241e587eab64b10a0c35dd455f6a2288a55 Mon Sep 17 00:00:00 2001 From: fiaxh Date: Wed, 22 Nov 2017 21:09:39 +0100 Subject: Fix memory leak --- main/src/ui/conversation_summary/message_populator.vala | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'main/src/ui/conversation_summary/message_populator.vala') diff --git a/main/src/ui/conversation_summary/message_populator.vala b/main/src/ui/conversation_summary/message_populator.vala index dc4b5770..df44a14b 100644 --- a/main/src/ui/conversation_summary/message_populator.vala +++ b/main/src/ui/conversation_summary/message_populator.vala @@ -55,8 +55,13 @@ public class MessagePopulator : Object { if (meta_item == null) return; meta_item.mark = message.marked; + WeakRef weak_meta_item = WeakRef(meta_item); + WeakRef weak_message = WeakRef(message); message.notify["marked"].connect(() => { - meta_item.mark = message.marked; + Plugins.MetaConversationItem? mi = weak_meta_item.get() as Plugins.MetaConversationItem; + Message? m = weak_message.get() as Message; + if (mi == null || m == null) return; + mi.mark = m.marked; }); item_collection.insert_item(meta_item); } -- cgit v1.2.3-54-g00ecf