| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In project_action_arguments_recursive(), IFS bindings needed to be
reworked in order to avoid a situation where, for example,
project_extract() would fail to extract source archives (because they
didn't exist), returning a status code of 1 only for it to be masked
by a rebinding of IFS--which would always succeed.
ifs_save and IFS were made local variables in
project_action_arguments_recursive() in order to avoid the need to
rebind IFS after the for loop returns.
This patch makes './libreboot sources <project>' functional.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
Located in libs/project, this array's elements are compared with actions
in PROJECTS_ACTIONS_GENERIC when libreboot_setup_project_actions() is
called. This makes it simpler to add/remove actions which
should/shouldn't have a corresponding check function in PROJECT_ACTIONS.
|
| |
| |
| |
| |
| |
| |
| | |
Located in libs/tool, this array's elements are compared with actions
in TOOLS_ACTIONS_GENERIC when libreboot_setup_tool_actions() is
called. This makes it simpler to add/remove actions which
should/shouldn't have a corresponding check function in TOOL_ACTIONS.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The added function is a complement to
libreboot_setup_project_actions() which moves generation of the
TOOL_ACTIONS array out of libs/tool and into the main script for
greater malleability.
Notably, the proper elements are now included in the array.
|
| |
| |
| |
| |
| |
| | |
Original naming did not have the '_FUNCTIONS' suffix, which made it
more clear as to the variable's purpose. This change reverts a
previous rename of mine made erroneously.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
The added function is called after all files in libs/ have been
sourced and provides the correct action sequence for 'test'.
Importantly, this function avoids providing undefined 'usage_check'
and 'clean_check' actions.
|
| |
| |
| |
| |
| |
| | |
When PROJECT_ACTIONS changed from having a string to an array of
strings as its value that change was not reflected in the main
script. This commit addresses that issue.
|
| |
| |
| |
| |
| |
| | |
Original naming did not have the '_FUNCTIONS' suffix, which made it
more clear as to the variable's purpose. This change reverts a
previous rename of mine made erroneously.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Local variables 'epoch_path' and 'rnd_seed_path' are moved from
libreboot_setup_variables() to
libreboot_setup_reproducible_builds_variables() in order to keep
things more-or-less lexical in the source code (local variables in
Bash are dynamic in scope).
|
|\ \
| |/
|/| |
|
| | |
|
| | |
|
|/ |
|
|\ |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|/
|
|
|
| |
Reproducibility-related variable assignments are moved to a separate
function in order to make libreboot_setup_variables() less busy.
|
|\ |
|
| | |
|
| |
| |
| |
| |
| |
| | |
The local variable 'arguments' always stores the positional parameters
passed to it as a string, not an array of strings, so usage of "$*"
makes more sense here instead of $@.
|
| | |
|
| | |
|
| | |
|
| | |
|
|/ |
|
|\ |
|
| |
| |
| |
| |
| | |
Now that it's done via CSS, code should be indented consistently
across the whole website.
|
|/
|
|
| |
This is a hack, and should really be done with CSS (see next commit).
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
Although it is unlikely that Tamil will be released in the near future,
the original text implied that free 3D on the C201 depends on the
release of Tamil. This is false; other projects can work on this. So,
this patch links to chai.
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Arrays are just a better idea for storing multiple strings than relying
on word splitting. Consequently, several global variables in libs/*
were switched to arrays and any references to said variables modified
to expand to the arrays' elements.
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It turns out that we only need bare HTML files for .md files in news,
yet publish.sh creates them unconditionally. That is, we spend a lot
of time building bare HTML files that we never use.
This commit makes it so that bare HTML files are only generated for
news files, which speeds up the website build significantly:
$ /home/michael/benchmark.sh speed-up-build master
Already on 'speed-up-build'
NOW TESTING ON speed-up-build
0m08.24s real 0m08.53s user 0m05.57s system
0m08.21s real 0m08.39s user 0m05.58s system
0m08.26s real 0m08.23s user 0m05.70s system
0m08.26s real 0m08.27s user 0m05.91s system
0m08.24s real 0m08.36s user 0m05.63s system
0m08.28s real 0m08.40s user 0m05.67s system
0m08.29s real 0m08.21s user 0m05.83s system
0m08.23s real 0m08.12s user 0m05.80s system
0m08.32s real 0m08.32s user 0m05.75s system
0m08.30s real 0m08.40s user 0m05.61s system
Switched to branch 'master'
Your branch is ahead of 'origin/master' by 33 commits.
NOW TESTING ON master
0m12.98s real 0m15.07s user 0m07.18s system
0m12.93s real 0m14.57s user 0m07.69s system
0m12.98s real 0m15.06s user 0m07.46s system
0m12.98s real 0m14.75s user 0m07.67s system
0m12.94s real 0m15.10s user 0m07.22s system
0m12.94s real 0m14.95s user 0m07.22s system
0m12.98s real 0m14.57s user 0m08.02s system
0m12.96s real 0m14.84s user 0m07.41s system
0m12.96s real 0m14.99s user 0m07.49s system
0m13.06s real 0m14.91s user 0m07.54s system
And here's the script in question, benchmark.sh:
#!/bin/sh
set -u
set -e
# usage: runit branch
runit() {
git checkout "$1"
echo
echo NOW TESTING ON "$1"
echo
for i in `jot 10`; do make clean >/dev/null; time make -j2 >/dev/null; done
}
make clean >/dev/null
for branch in "$@"
do
runit "$branch"
done
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
Unlike what the comment says, the target .md.html does apply to
news/index.md (it's just that news/index.md must be generated first
by index.sh).
|
|\ \ \
| |_|/
|/| | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When running "bash -x publish.sh index.md", the following happens:
+ pandoc --smart /tmp/libreboot_www.Xne7SYgf4e -s --css /global.css '--css /headercenter.css' --template template.html --metadata return=
pandoc: unrecognized option `--css /headercenter.css'
Try pandoc --help for more information.
This is because the OPTS variable is being quoted, which causes its
value of "-css /headercenter.css" to not be split on word boundaries,
that is, spaces. Because pandoc has a "--css" option, but not a
"--css /headercenter.css" option, pandoc expectedly complains that
said option does not exist.
To fix this we just unquote OPTS, and add a shellcheck ignore directive
so this won't be reintroduced in the future.
Caused by: a8d89665de6da20a8793886e03f153e922f6e519.
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| | |
All of the warnings were of type SC2086 [1]: Double quote to prevent
globbing and word splitting.
[1]: https://github.com/koalaman/shellcheck/wiki/Sc2086
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| | |
Splitting rss() into 3 smaller functions allows factoring the for-loop
out of rss() This is done by having the new rss_main() function take an
argument instead of operating on a global variable, as rss() did before.
|
| |
| |
| |
| |
| | |
I find it easier to read this file if all function definitions come
first, then all the actual stuff we do comes at the end.
|