From 4e3505463eadffd9f1994f8ecaba9b1d693ec7bf Mon Sep 17 00:00:00 2001
From: Andrew Robbins <contact@andrewrobbins.info>
Date: Wed, 25 Oct 2017 23:11:15 -0400
Subject: Modify fd copying in printf calls for readability

---
 libreboot | 50 +++++++++++++++++++++++++-------------------------
 1 file changed, 25 insertions(+), 25 deletions(-)

(limited to 'libreboot')

diff --git a/libreboot b/libreboot
index 218e09a5..dfda84b4 100755
--- a/libreboot
+++ b/libreboot
@@ -23,52 +23,52 @@ libreboot_usage() {
 	local action
 	local target
 
-	printf '%s\n' "$executable [action] [target] [arguments]" >&2
+	printf 1>&2 '%s\n' "$executable [action] [target] [arguments]"
 
-	printf '\n%s\n' 'Generic project actions:' >&2
+	printf 1>&2 '\n%s\n' 'Generic project actions:'
 
 	for action in "${PROJECT_ACTIONS_GENERIC[@]}"; do
-		printf '%s\n' "  $action" >&2
+		printf 1>&2 '%s\n' "  $action"
 	done
 
-	printf '\n%s\n' 'Virtual project actions:' >&2
-	printf '%s\n'   '  sources'
-	printf '%s\n'   '  produce'
-	printf '%s\n'   '  test'
+	printf 1>&2 '\n%s\n' 'Virtual project actions:'
+	printf 1>&2 '%s\n'   '  sources'
+	printf 1>&2 '%s\n'   '  produce'
+	printf 1>&2 '%s\n'   '  test'
 
-	printf '\n%s\n' 'Project targets:' >&2
+	printf 1>&2 '\n%s\n' 'Project targets:'
 
 	for target in "$root/$PROJECTS"/*; do
 		if project_check "$target"; then
-			printf '%s\n' "  $target" >&2
+			printf 1>&2 '%s\n' "  $target"
 		fi
 	done
 
-	printf '\n%s\n' 'Generic tool actions:' >&2
+	printf 1>&2 '\n%s\n' 'Generic tool actions:'
 
 	for action in "${TOOL_ACTIONS_GENERIC[@]}"; do
-		printf '%s\n' "  $action" >&2
+		printf 1>&2 '%s\n' "  $action"
 	done
 
-	printf '\n%s\n' 'Tool targets:' >&2
+	printf 1>&2 '\n%s\n' 'Tool targets:'
 
 	for target in "$root/$TOOLS"/*; do
 		if tool_check "$target"; then
-			printf '%s\n' "  $target" >&2
+			printf 1>&2 '%s\n' "  $target"
 		fi
 	done
 
-	printf '\n%s\n' 'Environment variables:' >&2
-	printf '%s\n'   '  PROJECTS_FORCE - Projects to always perform actions for' >&2
-	printf '%s\n'   '  TOOLS_FORCE - Tools to always perform actions for' >&2
-	printf '%s\n'   '  RELEASE_KEY - GPG key to use for release' >&2
-	printf '%s\n'   '  VBOOT_KEYS_PATH - Path to the vboot keys' >&2
-	printf '%s\n'   '  LIBFAKETIME_PATH - Path to the libfaketime shared library' >&2
-	printf '%s\n'   '  TASKS - Number of simultaneous tasks to run' >&2
-	printf '%s\n'   '  VERSION - Version string to use' >&2
-
-	printf '\n%s\n' 'Configuration files:' >&2
-	printf '%s\n'   "  $BUILD_SYSTEM.conf - Environment variables configuration" >&2
+	printf 1>&2 '\n%s\n' 'Environment variables:'
+	printf 1>&2 '%s\n'   '  PROJECTS_FORCE - Projects to always perform actions for'
+	printf 1>&2 '%s\n'   '  TOOLS_FORCE - Tools to always perform actions for'
+	printf 1>&2 '%s\n'   '  RELEASE_KEY - GPG key to use for release'
+	printf 1>&2 '%s\n'   '  VBOOT_KEYS_PATH - Path to the vboot keys'
+	printf 1>&2 '%s\n'   '  LIBFAKETIME_PATH - Path to the libfaketime shared library'
+	printf 1>&2 '%s\n'   '  TASKS - Number of simultaneous tasks to run'
+	printf 1>&2 '%s\n'   '  VERSION - Version string to use'
+
+	printf 1>&2 '\n%s\n' 'Configuration files:'
+	printf 1>&2 '%s\n'   "  $BUILD_SYSTEM.conf - Environment variables configuration"
 }
 
 libreboot_project() {
@@ -82,7 +82,7 @@ libreboot_project() {
 			if project_action_arguments 'extract' "$project" "$@"; then
 				return
 			else
-				printf '\n%s\n\n' 'Attempting to download instead...'
+				printf 1>&2 '\n%s\n\n' 'Attempting to download instead...'
 				project_action_arguments 'download' "$project" "$@"
 			fi
 			;;
-- 
cgit v1.2.3-70-g09d2