From f2afa101b39f8ddf2a57145d52716940c2230c2c Mon Sep 17 00:00:00 2001 From: Francis Rowe Date: Sun, 28 Dec 2014 21:24:28 +0000 Subject: ich9deblob: re-factored the descriptor deblob function --- .../ich9deblob/src/descriptor/descriptor.c | 104 ++++++++++----------- .../ich9deblob/src/descriptor/descriptor.h | 1 + resources/utilities/ich9deblob/src/gbe/gbe.h | 1 + 3 files changed, 53 insertions(+), 53 deletions(-) (limited to 'resources') diff --git a/resources/utilities/ich9deblob/src/descriptor/descriptor.c b/resources/utilities/ich9deblob/src/descriptor/descriptor.c index 1e434be1..467e2bd7 100644 --- a/resources/utilities/ich9deblob/src/descriptor/descriptor.c +++ b/resources/utilities/ich9deblob/src/descriptor/descriptor.c @@ -35,80 +35,78 @@ /* * Modify the flash descriptor, to remove the ME/AMT, and disable all other regions * Only Flash Descriptor, Gbe and BIOS regions (BIOS region fills factoryRomSize-12k) are left. - * Tested on ThinkPad X200 and X200S. X200T and other GM45 targets may also work. + * Tested on ThinkPad X200 and X200S. X200T and other GM45/GS45 targets may also work. * Also described in docs/hcl/x200_remove_me.html */ + +/* + * Remove the ME/AMT blobs. This is needed for the ICH9 machines (eg X200) + * to be compatible in libreboot. + * + * Disable the ME/Platform regions, re-locate Descriptor+Gbe+BIOS like so: + * Descriptor(4K), then Gbe (8K), then the remainder of the image is the BIOS region. + */ struct DESCRIPTORREGIONRECORD deblobbedDescriptorStructFromFactory(struct DESCRIPTORREGIONRECORD factoryDescriptorStruct, unsigned int factoryRomSize) { struct DESCRIPTORREGIONRECORD deblobbedDescriptorStruct; memcpy(&deblobbedDescriptorStruct, &factoryDescriptorStruct, DESCRIPTORREGIONSIZE); + /* + * Remove all those nasty blobs: + * ----------------------------- + */ + /* * set number of regions from 4 -> 2 (0 based, so 4 means 5 and 2 * means 3. We want 3 regions: descriptor, gbe and bios, in that order) */ deblobbedDescriptorStruct.flMaps.flMap0.NR = 2; - - /* - * make descriptor writable from OS. This is that the user can run: - * sudo ./flashrom -p internal:laptop=force_I_want_a_brick - * from the OS, without relying an an external SPI flasher, while - * being able to write to the descriptor region (locked by default, - * until making the change below): - */ - deblobbedDescriptorStruct.masterAccessSection.flMstr1.fdRegionWriteAccess = 1; - - /* relocate BIOS region and increase size to fill image */ - deblobbedDescriptorStruct.regionSection.flReg1.BASE = 3; // 3<> FLREGIONBITSHIFT) - 1); + /* - * ^ for example, 8MB ROM, that's 8388608 bytes. - * ^ 8388608>>FLREGIONBITSHIFT (or 8388608/4096) = 2048 bytes - * 2048 - 1 = 2047 bytes. - * This defines where the final 0x1000 (4KiB) page starts in the flash chip, because the hardware does: - * 2047<>FLREGIONBITSHIFT) is well outside the higher 8MB range. - */ + /* Disable (delete) the Platform region */ + deblobbedDescriptorStruct.regionSection.flReg4.BASE = 0x1FFF; + deblobbedDescriptorStruct.regionSection.flReg4.LIMIT = 0; + + /* Other steps needed for the deblobbing: */ + deblobbedDescriptorStruct.ichStraps.ichStrap0.meDisable = 1; /* Disable the ME in ICHSTRAP0 */ + deblobbedDescriptorStruct.mchStraps.mchStrap0.meDisable = 1; /* Disable the ME in MCHSTRAP0 */ + deblobbedDescriptorStruct.mchStraps.mchStrap0.tpmDisable = 1; /* Disable the TPM in MCHSTRAP0 */ - /* relocate Gbe region to begin at 4KiB (immediately after the flash descriptor) */ - deblobbedDescriptorStruct.regionSection.flReg3.BASE = 1; // 1<> FLREGIONBITSHIFT; + deblobbedDescriptorStruct.regionSection.flReg3.LIMIT = GBEREGIONSIZE_8K >> FLREGIONBITSHIFT; - /* set Platform region size to 0 - another blob that we don't want */ - deblobbedDescriptorStruct.regionSection.flReg4.BASE = 0x1FFF; // setting 1FFF means setting size to 0. 1FFF<> FLREGIONBITSHIFT; + deblobbedDescriptorStruct.regionSection.flReg1.LIMIT = (factoryRomSize >> FLREGIONBITSHIFT) - 1; + /* - * ^ 0<>FLREGIONBITSHIFT) is well outside the higher 8MB range. - */ - - /* disable ME in ICHSTRAP0 - the ME is a blob, we don't want it in libreboot */ - deblobbedDescriptorStruct.ichStraps.ichStrap0.meDisable = 1; - - /* disable ME and TPM in MCHSTRAP0 */ - deblobbedDescriptorStruct.mchStraps.mchStrap0.meDisable = 1; // ME is a blob. not wanted in libreboot. - deblobbedDescriptorStruct.mchStraps.mchStrap0.tpmDisable = 1; // not wanted in libreboot - - /* - * disable ME, apart from chipset bugfixes (ME region should first be re-enabled above) - * This is sort of like the CPU microcode updates, but for the chipset - * (commented out below here, since blobs go against libreboot's purpose, - * but may be interesting for others) - * deblobbedDescriptorStruct.mchStraps.mchStrap0.meAlternateDisable = 1; + * Other things: + * ------------- */ + + /* Make the flash descriptor region writeable from Host CPU / BIOS: */ + deblobbedDescriptorStruct.masterAccessSection.flMstr1.fdRegionWriteAccess = 1; return deblobbedDescriptorStruct; } diff --git a/resources/utilities/ich9deblob/src/descriptor/descriptor.h b/resources/utilities/ich9deblob/src/descriptor/descriptor.h index 8648c981..69d3358c 100644 --- a/resources/utilities/ich9deblob/src/descriptor/descriptor.h +++ b/resources/utilities/ich9deblob/src/descriptor/descriptor.h @@ -40,6 +40,7 @@ #include #include +#include "../gbe/gbe.h" /* Needed for GBEREGIONSIZE_4K/8K define */ /* size of the descriptor in bytes */ #define DESCRIPTORREGIONSIZE 0x1000 diff --git a/resources/utilities/ich9deblob/src/gbe/gbe.h b/resources/utilities/ich9deblob/src/gbe/gbe.h index 7ba59e27..867927d9 100644 --- a/resources/utilities/ich9deblob/src/gbe/gbe.h +++ b/resources/utilities/ich9deblob/src/gbe/gbe.h @@ -43,6 +43,7 @@ #include #include +#include "../descriptor/descriptor.h" /* Size of the full gbe region in bytes */ #define GBEREGIONSIZE_8K 0x2000 -- cgit v1.2.3-70-g09d2