From 85934d62d767a484fa560066b6edb69a18145690 Mon Sep 17 00:00:00 2001 From: Andrew Robbins Date: Thu, 26 Oct 2017 02:32:54 -0400 Subject: Replace usage of the '[' Bash builtin with '[[' There's no benefit to using the POSIX-style '[' test builtin considering its '-a' and '-o' operators are unused in the Libreboot build system. Plus, '[[' is safer with respect to any containing file redirections (for example). Prior, both '[' and '[[' were used throughout the codebase--a disparity in usage which this change aims to eliminate. --- tools/boot-keys/boot-keys-helper | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tools/boot-keys/boot-keys-helper') diff --git a/tools/boot-keys/boot-keys-helper b/tools/boot-keys/boot-keys-helper index 5d01916a..df53ec5b 100755 --- a/tools/boot-keys/boot-keys-helper +++ b/tools/boot-keys/boot-keys-helper @@ -13,7 +13,7 @@ boot_keys_cros() { local cros_scripts_path=$( project_install_path "cros-scripts" ) local cros_script_path="$cros_scripts_path/$cros_script" - if ! [ -x "$cros_script_path" ] + if ! [[ -x "$cros_script_path" ]] then printf 1>&2 '%s' "$cros_script script missing from cros-scripts install" return 1 @@ -37,7 +37,7 @@ boot_keys_files_install_path() { helper_arguments=$( project_action_helper "arguments" "$project" "$@" ) - if [ $? -ne 0 ] || [ -z "$helper_arguments" ] + if [[ $? -ne 0 ]] || [[ -z "$helper_arguments" ]] then project_install_path "$project" "$@" else -- cgit v1.2.3-70-g09d2