diff options
| author | Francis Rowe <info@gluglug.org.uk> | 2015-10-17 16:10:53 +0100 |
|---|---|---|
| committer | Francis Rowe <info@gluglug.org.uk> | 2015-10-17 19:07:35 +0100 |
| commit | 5999dba5f71f1c05040a551d2420ab8c7f3a9da4 (patch) | |
| tree | 7313b1996a247bf938417d5cf2496f5f6625c0db /resources/libreboot/patch/kgpe-d16/0052-southbridge-amd-sb700-Disable-broken-SATA-MSI-functi.patch | |
| parent | 4d909153e79661e54999e51693668f6d1ecc1cca (diff) | |
| download | librebootfr-5999dba5f71f1c05040a551d2420ab8c7f3a9da4.tar.gz librebootfr-5999dba5f71f1c05040a551d2420ab8c7f3a9da4.zip | |
New board: ASUS KGPE-D16
coreboot build errors:
In file included from src/northbridge/amd/amdfam10/misc_control.c:35:0:
src/include/option.h:13:27: error: static declaration of 'get_option' follows non-static declaration
static inline enum cb_err get_option(void *dest, const char *name)
^
In file included from src/northbridge/amd/amdfam10/misc_control.c:34:0:
src/include/pc80/mc146818rtc.h:176:13: note: previous declaration of 'get_option' was here
enum cb_err get_option(void *dest, const char *name);
Ping tpearson about this.
Also ping him about the fact that there isn't actually an option to
enable or disable native graphics initialization, but that the option
MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG is in fact available and set to Y in the
Kconfig file. I think this is probably since there isn't even an option
ROM available for the machine, so it's pointless to offer the setting.
Diffstat (limited to 'resources/libreboot/patch/kgpe-d16/0052-southbridge-amd-sb700-Disable-broken-SATA-MSI-functi.patch')
| -rw-r--r-- | resources/libreboot/patch/kgpe-d16/0052-southbridge-amd-sb700-Disable-broken-SATA-MSI-functi.patch | 39 |
1 files changed, 39 insertions, 0 deletions
diff --git a/resources/libreboot/patch/kgpe-d16/0052-southbridge-amd-sb700-Disable-broken-SATA-MSI-functi.patch b/resources/libreboot/patch/kgpe-d16/0052-southbridge-amd-sb700-Disable-broken-SATA-MSI-functi.patch new file mode 100644 index 00000000..01ff80a6 --- /dev/null +++ b/resources/libreboot/patch/kgpe-d16/0052-southbridge-amd-sb700-Disable-broken-SATA-MSI-functi.patch @@ -0,0 +1,39 @@ +From 173148993ede860eb9e00d5d6efee322f6b03424 Mon Sep 17 00:00:00 2001 +From: Timothy Pearson <kb9vqf@pearsoncomputing.net> +Date: Tue, 9 Jun 2015 19:12:35 -0500 +Subject: [PATCH 052/146] southbridge/amd/sb700: Disable broken SATA MSI + functionality + +--- + src/southbridge/amd/sb700/early_setup.c | 7 ++++--- + 1 file changed, 4 insertions(+), 3 deletions(-) + +diff --git a/src/southbridge/amd/sb700/early_setup.c b/src/southbridge/amd/sb700/early_setup.c +index 70a2aee..1f92a4e 100644 +--- a/src/southbridge/amd/sb700/early_setup.c ++++ b/src/southbridge/amd/sb700/early_setup.c +@@ -678,6 +678,7 @@ static void sb700_pci_cfg(void) + { + device_t dev; + u8 byte; ++ uint8_t acpi_s1_supported = 1; + + /* SMBus Device, BDF:0-20-0 */ + dev = pci_locate_device(PCI_ID(0x1002, 0x4385), 0); +@@ -730,10 +731,10 @@ static void sb700_pci_cfg(void) + byte = pci_read_config8(dev, 0x40); + byte |= 1 << 0; + pci_write_config8(dev, 0x40, byte); +- if (get_sb700_revision(pci_locate_device(PCI_ID(0x1002, 0x4385), 0)) <= 0x12) +- pci_write_config8(dev, 0x34, 0x70); /* set 0x61 to 0x70 if S1 is not supported. */ ++ if (acpi_s1_supported) ++ pci_write_config8(dev, 0x34, 0x70); /* Hide D3 power state and MSI capabilities */ + else +- pci_write_config8(dev, 0x34, 0x50); /* set 0x61 to 0x50 if S1 is not supported. */ ++ pci_write_config8(dev, 0x61, 0x70); /* Hide MSI capability */ + byte &= ~(1 << 0); + pci_write_config8(dev, 0x40, byte); + } +-- +1.7.9.5 + |